Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): Fix incorrect default value for fieldTypes #121

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

suevalov
Copy link
Contributor

Summary

Fixes a bug in contentful extension create and contentful extension update introduced in v0.19.0

Learnings

Don't use default values for type: array

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   81.85%   81.85%           
=======================================
  Files          56       56           
  Lines        1102     1102           
=======================================
  Hits          902      902           
  Misses        200      200
Impacted Files Coverage Δ
lib/cmds/extension_cmds/create.js 95.83% <ø> (ø) ⬆️
lib/cmds/extension_cmds/update.js 95.83% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2fd25c...bffff57. Read the comment docs.

@Khaledgarbaya Khaledgarbaya merged commit b52f6c3 into master Feb 20, 2019
@Khaledgarbaya Khaledgarbaya deleted the fix-broken-extension-create branch February 20, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants